#54 `make check` ignores failures
Closed: Fixed by rcritten. Opened by slev.

With the existing check make rule:

100 check:                                                                          
101         cd test;        \                                                       
102         rm -rf work;    \                                                       
103         nosetests -v test_cipher.py;    \                                       
104         if [ `id -u` != 0 ]; then       \                                       
105         ./setup.sh -s 1 dbm:;   \                                               
106         DBPREFIX=dbm: nosetests -v test.py;     \                               
107         sleep 5;        \                                                       
108         rm -rf work;    \                                                       
109         ./setup.sh -s 1 sql:;   \                                               
110         DBPREFIX=sql: nosetests -v test.py;     \                               
111         cd ..;  \                                                               
112         else    \                                                               
113         echo "Skipping live tests as they cannot be run as root";       \       
114         fi                                                                      
115

the overall result of testing doesn't depend on actual result of tests runner.


In my particular case,

Ran 27 tests in 452.875s
FAILED (errors=13)
make: Leaving directory '/usr/src/RPM/BUILD/apache2-mod_nss-1.0.18'
+ exit 0

Commit c29d3332 fixes this issue

Metadata
Related Pull Requests