mdapi

#58 Drop jsonp decorator from the branches endpoint
Merged by pingou. Opened by pingou.
fix_branches  into  master

Download 58.patch

The decorator to add support for JSONP doesn't seem to handle this
endpoint, so we just remove it and added back JSONP support manually.

Fixes https://pagure.io/mdapi/issue/55

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

2 new commits added

  • Drop the jsonp decorator from the branches endpoint and do it manually
  • Expose the upstream URL as present in the metadata in the JSON returned

This seems to be a repeat commit from another pull request. You might want to rebase this branch so it only contains the intended commit.

It would be good to document what doesn't work.

I recommend adding test coverage here. Test coverage would probably have helped detect the problem with the jsonp decorator, and can ensure the the function continues to work in the future.

LGTM.

I am not entirely sure what doesn't work I think it's to due with asyncio and coroutines, somehow this is returning an object instead of a generator.

I will add a note about this

This PR is based on the other one, once I merge the other one, this commit will be gone from this PR :)

rebased

rebased

Thanks for your review.

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.