#53 Add support for jsonp as returned format
Merged by pingou. Opened by pingou.
jsonp  into  master

Download 53.patch

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

For PEP-8 there should only be one space after the =.

Since request is always args[0], you could put it in the signature of wrapper above and drop this line. It'd be a little cleaner, and you can also add request to the docblock so its clear to the users of this wrapper that the first arg must be a request.

This change seems unrelated to the JSONP stuff. I recommend a separate commit for it so this commit is atomic.

I recommend targeted tests for the new code. LGTM!

I'll fix

Good idea, I'll give it a try

This entire project would require tests, but that's a task for another day :)

rebased

1 new commit added

  • Add missing coroutine declaration

All adjusted and split into 2 commits :)

Thanks for the review!

Pull-Request has been merged by pingou

Metadata