#33 get_repo_md: handle gzip correctly
Merged by pingou. Opened by puiterwijk.
puiterwijk/mdapi handle-gzip  into  master

Download 33.patch
no initial comment

Looks good to me.

AFAIK it was working as such, did something change?

There were no repos actually using gzip until yesterday, when el5-testing switched.
And no, the tarfile approach did not work, check the tons of emails about the cron failing :).

I'm fairly sure I tested this but ok. Will gzip support .tar.gz?

It will give a .tar.
But I don't think we ever have a .tar.gz repo information, as it's pretty much all .xml.gz or .sqlite.gz.
And tarfile doesn't do .sqlite.gz, since it's not a tarball.

So if we do want to support .tar.gz, we should probably make it first see if the extension is .tar.gz, in which case we retain the tarfile operations, and otherwise we check for .gz and then fall back to using the gzip module.

So if we do want to support .tar.gz, we should probably make it first see if the extension is .tar.gz, in which case we retain the tarfile operations, and otherwise we check for .gz and then fall back to using the gzip module.

:thumbsup: it's also what I had in mind

Pull-Request has been rebased

Pull-Request has been merged by pingou

Metadata