#110 Add CORS headers to 404s too.
Merged by pingou. Opened by qulogic.
qulogic/mdapi cors404  into  master

Download 110.patch

Though maybe you'll want to add it to any error result.

Maybe fixes #89, perhaps.

Also not sure if you would also like the Content-Type to be switched to application/json as originally reported in #89.

I'm wondering if restricting to 404 only makes sense, what do you think?

It may not be necessary, that was just the minimal change.

rebased onto 6234462be9787731c5d0eac0ae43bbea0e774386

I changed it to always add headers, but it may be good to also always return JSON, see #111.

+1 to always return JSON but it should be complementary to the http code I think.

For this PR, I'm +1 with the code change itself, but I think the commit message needs to be adjusted :)

rebased onto d752db65f9aef0147ade8dab40c44cbd82f2f5e6

Ah right, fixed now.

rebased onto a246e354a1c3f486dde52ae7da02bec9bb5ba40e

rebased onto 90d32f0f2a519db9956ee926404ab28c3f8c5502

Thanks for this! :)

Pull-Request has been merged by pingou

Metadata