#12 Handle GNOME welcome app .desktop file rename
Merged by adamwill. Opened by adamwill.
adamwill/livesys-scripts anaconda-welcome-renamed  into  main

Download 12.patch

anaconda renamed the .desktop file for the GNOME live 'welcome'
app. We need to cope with that. This handles both names, so we
can use the same code on F39+ and <F39.

Signed-off-by: Adam Williamson awilliam@redhat.com

Looks good to me (I think it was my code from the beginning).

I'd maybe put do on the same line like
for deskname in org.fedoraproject.welcome-screen.desktop fedora-welcome.desktop; do
so that it matches the if []; then block but that's just a tiny nit :)

rebased onto bb6017d04150874e10a403dcef52cd8f168cddbd

Updated, thanks.

openQA tests of a scratch build are running. Note, tests may fail due to a subsequent bug which I'm still investigating (or, I guess, due to the welcome screen being redesigned - I'll need to update openQA's needles, probably), but if the welcome screen at least shows up, this bug is fixed.

:thumbsup:

Gah. The worker the test was running on went weird so I had to reboot it. Test will have to restart.

Sigh. It's not the worker. It's yet another new bug in Rawhide. Seems to be util-linux. That's four separate bugs today so far. whee

OK, test got far enough to show that this works.

Pull-Request has been merged by adamwill

Metadata