PR#58: Fixing fs_test -

libuser

#58 Fixing fs_test

Merged Jan 23, 2023 by thalman. Opened Jan 20, 2023 by thalman.

thalman/libuser fs_test into master

thalman commented Jan 20, 2023

The fs_test did not work for sometime. Fixed issues are:
- some tests are not working under fakeroot, particularly the fakeroot provided in pseudo package
- mkfifo does not work in fakeroot, but the test still runs fine
- no information is printed what test actually failed
- different behavior when the files are stored on xfs or btrfs

Metadata Update from @thalman:
- Request assigned

Jan 20, 2023

ipedrosa commented Jan 23, 2023

If the tests work well without mkfifo, then why do you need to use it?

thalman commented Jan 23, 2023

If the tests work well without mkfifo, then why do you need to use it?

because if you have better implementation of fakeroot or you run the tests as root then the test covers more use-cases. So I decided to keep it.

ipedrosa commented Jan 23, 2023

But, if it fails, then does it mean it does nothing? It's kind of strange that if the command fails then the test can success. I don't know if you follow me.

thalman commented Jan 23, 2023

The test creates various objects on the filesystem (files, hard-links, symlinks, fifo) and then it uses the library to check if it can actually delete folder containing such objects (home of a user that is being deleted is the practical use-case).

Not having a fifo object in the folder is just unfortunate for the test. But skipping the test completely just because running as non-root would be a pity.

There is still value in running the test even without fifo object.

Edited Jan 23, 2023 by thalman

ipedrosa commented Jan 23, 2023

Now I understand it. Thanks for the explanation.

LGTM!

thalman commented Jan 23, 2023

Thanks for review

thalman commented Jan 23, 2023

Commit dcfd9e97 fixes this pull-request

Pull-Request has been merged by thalman

Jan 23, 2023

Pull-Request has been merged by thalman