libuser

#37 lock_file_create: Set and reset umask before and after creating the lockfile
Closed by thalman. Opened by jhrozek.
jhrozek/libuser umask_mkstemp  into  master

Download 37.patch

Merges:
https://pagure.io/libuser/issue/25

This is not a big deal, but static analyzers are happier when umask is
set explicitly.

OTOH see https://bugzilla.redhat.com/show_bug.cgi?id=908786 , modifying umask in a library called from a possibly-threaded program is problematic.

(I don’t have a better answer though; both doing this and not doing this is wrong.)

I was sort of expecting this answer :) I'm actually more inclined to close this PR and the issue and just maintain the status quo. The issue is not a big deal anyway IMO.

I also think that we should not do that, closing this staled PR

Pull-Request has been closed by thalman
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.