libuser

#34 lu_dispatch: Free tmp on failures
Merged by thalman. Opened by jhrozek.
jhrozek/libuser free_tmp  into  master

Download 34.patch

Merges:
https://pagure.io/libuser/issue/23

This makes the code slightly less compact with using an explicit
condition instead of the g_return_val_if_fail() shorthand, but freeing
tmp on failures.

g_return_val_if_fail also logs a critical error; maybe use g_return_val_if_reached to preserve that?

(I’m honestly not all that sold on the g_*_if_fail style of error “handling”. But if it’s worth doing at all, it’s worth doing consistently.)

LGTM, thank you for the patch. ACK

Commit 22da5ca8 fixes this pull-request

Pull-Request has been merged by thalman

Pull-Request has been merged by thalman
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.