PR#43: [_call_api] Use concise exception message when wrong url -

libpagure

#43 [_call_api] Use concise exception message when wrong url

Merged May 15, 2019 by cverna. Opened May 10, 2019 by jpopelka.

jpopelka/libpagure call-api-404 into master

jpopelka commented May 10, 2019

As you can see in https://github.com/packit-service/packit/issues/305 one gets a cryptic
Error while decoding JSON: Expecting value: line 1 column 1 (char 0)
when _call_api() requests a wrong url (for more details see https://github.com/packit-service/ogr/issues/67).

ttomecek commented May 15, 2019

LGTM

cverna commented May 15, 2019

Cool thanks @jpopelka @ttomecek do you guys want commit permissions to this project ?

Pull-Request has been merged by cverna

May 15, 2019

ttomecek commented May 15, 2019

As @lachmanfrantisek indicated in some issue (can't find it right now) we are considering of dropping usage of libpagure and talk to pagure api directly in our ogr library.

Yes, having commit access would help us, but at the same time, we have already developed a library which we use a lot. Should we talk about this in person?

Metadata

Assignee

None

Tags

No Tags

libpagure

#43 [_call_api] Use concise exception message when wrong url Merged May 15, 2019 by cverna. Opened May 10, 2019 by jpopelka. jpopelka/libpagure call-api-404 into master

Metadata

#43 [_call_api] Use concise exception message when wrong url

Merged May 15, 2019 by cverna. Opened May 10, 2019 by jpopelka.

jpopelka/libpagure call-api-404 into master