PR#20: __call_api: Replace private with protected method -

libpagure

#20 __call_api: Replace private with protected method

Merged Mar 30, 2017 by yangl1996. Opened Mar 24, 2017 by mbasti.

mbasti/libpagure protected-method into master

mbasti commented Mar 24, 2017

private method makes it harder for developer to inherite from Pagure class
and update it with own methods. There is no need for __call_api to be
private. Is enough to have _call_api which can be used in inherited classes.

rebased

Mar 28, 2017

mbasti commented Mar 28, 2017

Dependencies have been pushed

bowlofeggs commented Mar 28, 2017

Python doesn't really have protected methods (or private) - the underscore is just a convention used to indicate that an API isn't intended to be a public interface (i.e., outsiders shouldn't rely on it being stable/maintained).

bowlofeggs commented Mar 28, 2017

Looks fine to me, I just would avoid the word protected (and private) and just describe what the method does. I think you can rely on API users to know the convention of underscores to mean "don't rely on this".

mbasti commented Mar 29, 2017

Description updated

rebased

Mar 29, 2017

mbasti commented Mar 29, 2017

Can we expect a new release as a new pagure version has been deployed?

yangl1996 commented Mar 30, 2017

Merged.

Pull-Request has been merged by yangl1996

Mar 30, 2017

yangl1996 commented Mar 30, 2017

v0.9 released. Thank you for all those pull requests :D