jss

#23 Perl code style problems on all.pl as revealed by our checking tool
Closed: fixed Opened by emaldonado.

Closed: fixed
Reopen Issue

Run the code style checking script for Perl aginst org/mozilla/jss/test/all.pl poor code style.
I ran perl -Mstrict -Mdiagnostics -cw org/mozilla/jss/tests/all.pl 1> ../all_pl_check.log 2>&1

Results of the check
check_all.txt

Yep, i'm aware that this is an issue; I haven't yet gotten around to fixing it, hence why it isn't in our test cases yet. :)

Thanks for reporting it!

Metadata Update from @cipherboy:
- Custom field component adjusted to None
- Custom field feature adjusted to None
- Custom field origin adjusted to None
- Custom field proposedmilestone adjusted to None
- Custom field proposedpriority adjusted to None
- Custom field reviewer adjusted to None
- Custom field type adjusted to None
- Custom field version adjusted to None

Metadata Update from @cipherboy:
- Issue assigned to cipherboy

Patch to clean up the code

cleanupTestScript.pl

After applying reran the check
$ perl -Mstrict -Mdiagnostics -cw org/mozilla/jss/tests/all.pl
and got
org/mozilla/jss/tests/all.pl syntax OK

In the patch this change is not needed
-createpkcs11_cfg;
+createpkcs11_cfg();

Metadata Update from @cipherboy:
- Issue close_status updated to: fixed
- Issue status updated to: Closed (was: Open)

This was addressed in jss pr#31. It went into upstream master in e29dd75e.

Metadata
None
None
None
None
None
None
None
None
None
None
None
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.