Just to be sure: does this write extra logging versus the old code if debug=False?
It does not. More messages will appear though because they were being suppressed by the log.screen = False.
Right. Would it possibly be good to set log.screen to the same value as debug? Or are the extra messages not that many and/or actually useful in a non-debug situation?
log.screen False causes log.[info|warn|error] to do not be logged.
If we find messages logged at the wrong level then we can address those separately.
Ah, okay. Thanks for the info.
Looks good to me.
Note that you forgot the signed-off-by line, are you okay with me adding that for you?
Yes, please add the missing signed-off-line. Thanks.