ipsilon

#392 Fix tests
Merged by ngompa. Opened by zlopez.
zlopez/ipsilon fix_tests  into  master

Download 392.patch

With upgrading of dev environment to F38 and updating test containers to F38 I tried to fix all the tests.

Unfortunatelly, there is one issue, which I tracked to https://pagure.io/ipsilon/blob/acd44b0d7495364a9be01bca932731ad21c1d29d/f/ipsilon/providers/saml2/auth.py#_387 and it seems that this is randomly failing tests in F38. All other container tests are passing, only the F38 is failing now. The issue is hard to debug, because there isn't any error anywhere in the test logs and the python-lasso is just a wrapper over .so C library. I even tried to downgrade to same version as on F37, but it doesn't seem to work on F38.
Hopefully the issue will be fixed in newer versions of lasso library.

I'm thinking about downgrading the vagrant dev env to F37, where the tests are currently passing. What do you think?
I can also remove F38 from containertest Makefile target, so the tests are passing for now.

I'm thinking about downgrading the vagrant dev env to F37, where the tests are currently passing. What do you think?

That should be okay for now, yeah.

Here is a separate PR for F37 https://pagure.io/ipsilon/pull-request/394

I will rebase this one once the F37 PR is merged

rebased onto 0a90965efcb018f00eabe9040cb994032ef0fd5c

And done

Pull-Request has been merged by ngompa
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.