ipsilon

#295 Kill the Persona IdP plugin
Closed by t0xic0der. Opened by puiterwijk.
puiterwijk/ipsilon personaisdead  into  master

Download 295.patch

I have explicitly not removed the entries from the dbupgrades script, to make sure that we verify we work correctly in upgrade cases.

Sad to see it go, but LGTM

Only one comment though.
The failure on plugin loading was intentional, as otherwise some missing plugins that may restrict access would cause auth to fail open.
I would rather just explicitly handle retired plugins in a white list to allow upgrades to not fail but not allow all plugins to fail without consequences.

Just my 2c

Probably worth removing the reference to Persona in man/ipsilon-server-install.1 too. Do we want to add an obsolete to the spec file too?

Simo raises a good point too, but I'm happy with going with this fix for now, and filing an issue to do it "properly" later on.

Beyond that, looks good.

LGTM

Pull-Request has been closed by t0xic0der
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.