ipsilon

#284 Fix passing relaystate "'None'" when no RelayState was in the request
Merged by puiterwijk. Opened by puiterwijk.
puiterwijk/ipsilon relaystatenonetest  into  master

Download 284.patch

Fixes #283.

Do note that this branch is based on the test framework rework branch.
As a result, this depends on getting that merged.

I interpreted your comment to mean that it was reasonable for me to review only the 4 newest commits and ignore the others (since they are in another PR presumably?). LGTM on the 4 newest!

nit: s/and/an/

Other than the nit, LGTM for last 4.

Thanks. As soon as I get an ack on #280, I'll also get this one merged.

8 new commits added

  • saml2: Do not send a RelayState with POST binding if not requested
  • tests.test1: Add test case for no RelayState
  • tests.helpers: Allow limiting redirects and posting forms
  • Replace mutable default arguments
  • Use automated test detection in Makefile
  • Update tests to use new test framework
  • Rework test framework
  • Allow passing stdout and stderr to tests

Commit cd46749c fixes this pull-request

Pull-Request has been merged by puiterwijk@redhat.com
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.