PR#266: Implement OpenID Connect unauthenticated clients -

ipsilon

#266 Implement OpenID Connect unauthenticated clients

Merged Apr 20, 2017 by puiterwijk. Opened Mar 13, 2017 by puiterwijk.

puiterwijk/ipsilon oidc-secretless into master

puiterwijk commented Mar 13, 2017

Unauthenticated clients mean that they have auth_method set to None.
This means that they do not have a way to reasonably store a secret, for e.g. client-side utilities.

These clients do not have access to any of the Ipsilon APIs with their client credentials.

bowlofeggs commented Mar 14, 2017

The second commit message has a typo: s/sspecify/specify/.

bowlofeggs commented Mar 14, 2017

This variable name is confusing given the variable name above it. I suggest adding a comment above it explaining what it is and how it is different from api_client_authenticated, or picking a more differentiated name.

bowlofeggs commented Mar 14, 2017

LGTM.

rebased

Mar 22, 2017

simo commented Mar 28, 2017

As far as enablement go this code LGTM.

merlinthp commented Apr 20, 2017

LGTM.

puiterwijk commented Apr 20, 2017

Commit 5a121656 fixes this pull-request

Pull-Request has been merged by puiterwijk@redhat.com

Apr 20, 2017