#62 Add additional gobuildflags macros
Merged by gotmax23. Opened by gotmax23.
gotmax23/go-rpm-macros goflags  into  master

Download 62.patch

https://copr.fedorainfracloud.org/coprs/gotmax23/go-rpm-macros-3.4.0_2.20240224.c9593e5/

See https://src.fedoraproject.org/rpms/aerc/pull-request/6 for example usage.

4 new commits added

  • Add support for GO_BUILDTAGS and GO_LDFLAGS macros
  • Include -trimpath in default build flags
  • Add additional gobuildflags macros
  • rpmeval.sh: remove extra newline

rebased onto baaf3c21562886fa1f2df91c2e4259eb8e839699

You mean $GO_LDFLAGS?

Does this supersede #41?

You mean $GO_LDFLAGS?

Yes. Thanks!

Does this supersede #41?

I think so. I really want to avoid pushing breaking changes to macros without a deprecation period.

4 new commits added

  • Add support for GO_BUILDTAGS and GO_LDFLAGS macros
  • Include -trimpath in default build flags
  • Add additional gobuildflags macros
  • rpmeval.sh: remove extra newline in output

@ngompa, PTAL

-trimpath apparently breaks debuginfo collection, so I'll drop that commit...

3 new commits added

  • Add support for GO_BUILDTAGS and GO_LDFLAGS macros
  • Add additional gobuildflags macros
  • rpmeval.sh: remove extra newline in output

Okay, I did my normal build a hundred random Go packages that currently build successfully according to Koschei routine in https://copr.fedorainfracloud.org/coprs/gotmax23/go-rpm-macros-3.4.0_3.20240229.bc7e5cc/builds/, so this should be good to go.

Pull-Request has been merged by gotmax23

Metadata