Fix issue 25
Any suggestions @eclipseo ? I'm not quite sure about including it in the %{?gocompilerflags} because it is used in go test and -trimpath is just for go build but I see duplicated flags so not really sure.
%{?gocompilerflags}
go test
-trimpath
go build
Also, do you think this could affect somehow the builds? Can't think of anything but better safe than sorry.
This seems okay to me as is, but I don't know if it could affect the builds. A beta test in COPR might be useful.
You should probably edit %gobuildflags() too?
I've tested some builds in a COPR: https://copr.fedorainfracloud.org/coprs/eclipseo/trimpath/builds/
They all fail, apparently no debuginfo are generated.
After considering it and talking with coworkers about why this flag was not included before, I think it doesn't make any sense, mainly because Koji builds in a sanitized build root, so nothing to leak. The same thing goes for reproducible builds.
I'll add a comment to the issue just in case there's something I'm missing. But otherwise, I think I should drop my PR :smile:
Pull-Request has been closed by alexsaezm
Fix issue 25