#19 LDFlags Macro Typos
Closed by eclipseo. Opened by bex.

While working with a new package, I needed some LDFlags passed. I am using this construction in my spec:

%build
LDFLAGS="-X foo=bar "
%gobuild ...

I have to put the space in quotes at the end as we appear to have space expansion errors. I was talking to @ignatenkobrain and he pointed out:

  • https://pagure.io/go-rpm-macros/blob/master/f/rpm/macros.d/macros.go-rpm#_353
    there is a missing space

  • https://pagure.io/go-rpm-macros/blob/master/f/rpm/macros.d/macros.go-compilers-gcc#_29
    ${LDFLAGS:-%{?currentgoldflags}} ← should be like that


Metadata Update from @qulogic:
- Issue assigned to nim

Please fix; this causes indecipherable errors without a space.

Will be in the next build.

Metadata Update from @eclipseo:
- Issue status updated to: Closed (was: Open)

Metadata
Related Pull Requests