From d82a0129a4037b8db2d85383a15f8f68a71d3ad0 Mon Sep 17 00:00:00 2001 From: Jan Kaluza Date: Sep 27 2017 14:22:40 +0000 Subject: Do not print whole message in case BaseEvent was not created - print just message id instead. --- diff --git a/freshmaker/consumer.py b/freshmaker/consumer.py index d52f8d4..1b30181 100644 --- a/freshmaker/consumer.py +++ b/freshmaker/consumer.py @@ -94,7 +94,8 @@ class FreshmakerConsumer(fedmsg.consumers.FedmsgConsumer): msg = self.get_abstracted_msg(message['body']) if not msg: - log.debug("Received unparsed message: %r", message) + # Logging is done in get_abstracted_msg, because we know + # the msg_id there... return # Primary work is done here. @@ -123,7 +124,12 @@ class FreshmakerConsumer(fedmsg.consumers.FedmsgConsumer): 'Received message does not contain "msg_id" or "message-id": ' '%r' % (message)) - return events.BaseEvent.from_fedmsg(message['topic'], message) + msg = events.BaseEvent.from_fedmsg(message['topic'], message) + if not msg: + log.debug("No BaseEvent subclass defined for message with id %s", + message["msg_id"]) + + return msg def process_event(self, msg): log.debug('Received a message with an ID of "{0}" and of type "{1}"'