freshmaker

#88 Set the build(s) to FAILED state in case of error.
Merged by ralph. Opened by jkaluza.
jkaluza/freshmaker container-build-submit  into  master

Download 88.patch
no initial comment

A description here is probably nice to have. ;)

In the future, this will be a good place to add message publication.

Looks fine code wise.

Any tests to add or alter?

I can add tests.

1 new commit added

  • Fix various issues found by testing Freshmaker with real depending services:

1 new commit added

  • Set the build(s) to FAILED state in case of error.

I'm wondering if you could just log the error in build.transition instead of having to do log.error and build.transition every time.

Please remove these comments.

Is it worth updating the state_reason here in case it is different?

Minor comments. After addressing them, +1.

I agree. good idea.

rebased onto 28dd5cd2025a2c589114cdef3f0085d90f48f447

Added tests, moved logging to transition method and also marking the artifact builds depending on the one for which the transition was called as FAILED or CANCELLED.

rebased onto 6bfd9463493d4893f88282b90ad1a72c418eab88

Any idea how frequent this is?

Not a blocker - just curious.

:+1:

Thanks!

Pull-Request has been merged by ralph
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.