This patch is for finding docker images to rebuild by using existing Errata Tool, Pulp and LightBlue APIs.
Signed-off-by: Chenxiong Qi cqi@redhat.com
Demo: https://fedorapeople.org/groups/factory2/sprint-032/cqi-freshmaker-find-docker-images-with-brew-and-lightblue.ogv
Nothing wrong about this - but are you planning to use this later? it doesn't seem to be used now
Perhaps not necessary ATM, but we might want to do a logical "OR" query on Pulp instead to speed things up (i.e. one query instead of one query for pulp repo id)
"found".
Generally looks good, will wait for final version for deeper review.
Need to get build NVR in order to get build target and extract branch name from that target.
Good point. I'll learn Pulp API deeply. Or, any hint at this moment? :)
It's basically just: "filters": { "$or": [ {"notes.content_set": "content-set-1"}, {"notes.content_set": "content-set-2"} ] }
Right! LGTM then
rebased
Major updates:
Errata.build_signed
advisory/errata_id/builds.json
_errata_http_get
Pulp.get_content_set_by_repo_ids
KOJI_PROFILE
Please review.
I am fairly certain not all returned will always have content_set in notes - so you could end up with KeyError here
What Stano wrote, otherwise +1 from me.
Fixed issue mentioned by @sochotni
+1
Pull-Request has been merged by cqi
This patch is for finding docker images to rebuild by using existing
Errata Tool, Pulp and LightBlue APIs.
Signed-off-by: Chenxiong Qi cqi@redhat.com
Demo: https://fedorapeople.org/groups/factory2/sprint-032/cqi-freshmaker-find-docker-images-with-brew-and-lightblue.ogv