From e2e1395a72504452d2bf3135f4889d98ee72d7d2 Mon Sep 17 00:00:00 2001 From: mprahl Date: Nov 20 2019 21:27:39 +0000 Subject: Rename filter_out_images_with_lower_srpm_nvr to filter_out_images_with_higher_srpm_nvr Since this method actually removes the images with higher SRPM NVRs, it should be renamed to reduce confusion. --- diff --git a/freshmaker/lightblue.py b/freshmaker/lightblue.py index c83746a..8fb11cb 100644 --- a/freshmaker/lightblue.py +++ b/freshmaker/lightblue.py @@ -728,7 +728,7 @@ class LightBlue(object): ] return projection - def filter_out_images_with_lower_srpm_nvr(self, images, srpm_name_to_nvrs): + def filter_out_images_with_higher_srpm_nvr(self, images, srpm_name_to_nvrs): """ Checks whether the input NVRs defined in `srpm_name_to_nvrs` dict are newer than the matching SRPM NVRs in the container image. @@ -923,7 +923,7 @@ class LightBlue(object): new_images.append(image) break images = new_images - images = self.filter_out_images_with_lower_srpm_nvr(images, srpm_name_to_nvrs) + images = self.filter_out_images_with_higher_srpm_nvr(images, srpm_name_to_nvrs) images = self.filter_out_non_modular_container_images(images, srpm_name_to_nvrs) return images @@ -1003,7 +1003,7 @@ class LightBlue(object): images = self.find_container_images(image_request) if srpm_nvrs is not None: - images = self.filter_out_images_with_lower_srpm_nvr(images, srpm_name_to_nvrs) + images = self.filter_out_images_with_higher_srpm_nvr(images, srpm_name_to_nvrs) return images def find_unpublished_image_for_build(self, build):