Signed-off-by: gnaponie gnaponie@redhat.com
rebased onto 2a90cca1b063a92e2db28baf40513202263bdc23
@jkaluza @lucarval PTAL. I think I covered everything, but I might have missed something...
I think, you can also remove funcsigs stuff (requirements.txt and freshmaker/events.py).
funcsigs
requirements.txt
freshmaker/events.py
The python3-funcsigs is probably also not needed.
python3-funcsigs
What in the world is python-fedora ? UPDATE: Apparently it's "Python modules for talking to Fedora Infrastructure Services" I don't think it's being used. Maybe we can remove it in a future PR. It's beyond the scope of this PR.
python-fedora
We should probably also remove the usage of six library and usage of from __future__.
six
from __future__
It looks good for me. I think we can try merging that and see if it builds and works on freshmaker dev.
rebased onto a58bd6b7bd475d5a1e7d537c2b939c428edb96d5
I've rebased addressing the comments. I agree with Jan, once it's merged let's check if devs works correctly.
@lucarval @lholecek can you review again?
+1
Pull-Request has been merged by gnaponie
Signed-off-by: gnaponie gnaponie@redhat.com