freshmaker

#396 Add option to show a shortened version of the JSON in the API to speed up loading times
Merged by jkaluza. Opened by srieger.
srieger/freshmaker master  into  master

Download 396.patch
no initial comment

We need to test (outside of tox) that this will significantly improve performance. Also if this approach is ok, where should the documentation be updated?
Edited by srieger

rebased onto 9a66851e79321167353538a8a7265c1cc160022c

rebased onto 9a66851e79321167353538a8a7265c1cc160022c

I like the idea with json_min(), that's exactly what we want.

I think instead of using the show_full_json variable which is True by default, we should really introduce the second version of API where this variable would be False by default. The reason is that with full output, the Freshmaker API is really not usable and timeouts. This way should not be default one.

It could look like this (+ tests):

https://paste.fedoraproject.org/paste/oN1QpyURhG0T5UA78Nouqw

rebased onto 44e9ba7aef73292ebb59f0bf1677f15e6284c87f

rebased onto 6403bd30664d39151544929264d2ec79d985645d

pretty please pagure-ci rebuild

pretty please pagure-ci rebuild

rebased onto d70bdcc76ec3401f026f5e687deb7368949201cd

Can you also write another test for /api/2/events without the show_full_json and test that it returns short json?

rebased onto aaa870a6e1d304672fb04104e5953b9c17de5a1e

Try with this patch: https://paste.fedoraproject.org/paste/XnUduCORaRVB8z4DnBEgFw

rebased onto 9d0482428f679581d91eb638e47fafcb3f3168f3

Commit 0f04dcb5 fixes this pull-request

Pull-Request has been merged by jkaluza

Pull-Request has been merged by jkaluza
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.