freshmaker

#368 Add new "/verify-image" and "/verify-image-repository" API endpoints.
Merged by jkaluza. Opened by jkaluza.
jkaluza/freshmaker verify-api  into  master

Download 368.patch

These are used to verify whether all conditions are satisfied for particular
container image repository or container image. This will allow container
image maintainers to check if their images are set up properly to be considered
for a rebuild by Freshmaker.

This saves me lot of time when debugging these issues with maintainers.

Instead of returning a list of repository objects, suggest to just return one. This could make it easier to understand the method which calls this one.

@cqi, context?

rebased onto 52893be4b4f76a28a9c116777b4c3e82f4180a40

Updated based on the @cqi comment.

what rtype stands for?

like return type? you alredy specified that in the return clause.

@jkaluza generally looks good, only minor nitpick with regards to the double documentation of return types.

That comes from docstring, for example: https://thomas-cokelaer.info/tutorials/sphinx/docstring_python.html.

But I admit I/we use ":param type name:" which is not mentioned there... :( Probably it does not make sense to use :rtype: either.

Pull-Request has been merged by jkaluza
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.