#275 Handle situation when released image depends on unreleased image foo, and we also want to rebuild released version of image foo.
Merged by jkaluza. Opened by jkaluza.
jkaluza/freshmaker ccache-per-thread  into  master

Download 275.patch

This PR handles following situation:

  • latest released version of "foo" image is "foo-1-1"
  • latest released version of "bar-1-1" image depends on unreleased "foo-1-2".

There were two issues which this PR fixes:

  • The deduplication code decided that we will rebuild "foo-1-2" both as dependency of "bar-1-1" and also as standalone image. This was wrong, because "foo-1-2" was never released and therefore we should not build that version as standalone image.
  • The unreleased "foo-1-2" was not in any container repository and therefore the content_sets were not set properly for it and the build failed.

This PR fixes the issues following way:

  • The deduplication code now checks what is the latest released NVR of "foo" and and deduplicates only NVRs which are lower than that. That means that we will rebuild "foo-1-1" as standalone image in our case and "bar" will be rebuilt against "foo-1-2".
  • If the unreleased version of image is found, the content_sets are copied from the released ones.

Why remove the krb tests here?

It is a reasonable guess.

:+1:

Those loops made my head spin. The comments helped me through!

We have stopped using python-krbcontext in previous commits but I forgot to remove these tests and they were failing.

Commit e9f8fd61 fixes this pull-request

Pull-Request has been merged by jkaluza

Pull-Request has been merged by jkaluza

Metadata