#9791 test_ipa_healthcheck_fips_enabled xfail annotation is incorrect
Closed: fixed by frenaud. Opened by frenaud.

Issue

The test test_integration/test_ipahealthcheck.py::TestIpaHealthCheck::test_ipa_healthcheck_fips_enabled defines an xfail annotation that is incorrect.

The current annotation expects a test failure if ipa-healthcheck < 0.17 and RHEL 10.0+ are involved but it needs to be updated.

  • On RHEL 10.0 the test would fail because it ships ipa-healthcheck 0.16-7 which doesn't contain the patch for the removal of fips-mode-setup command
  • On RHEL 10.1+ the test should succeed because it ships ipa-healthcheck 0.16-9 which contains the fix (RHEL-67635)
  • on fedora 41 and below, the test should succeed because fips-mode-setup command is available
  • on fedora 42 and above, the fips-mode-setup command has been removed, and the test should succeed if ipa-healthcheck version is >= 0.18 because it contains the patch (https://github.com/freeipa/freeipa-healthcheck/commit/f42dc7bbbd336ee888942a9aff8a55b000e4108e)

Metadata Update from @frenaud:
- Custom field on_review adjusted to https://github.com/freeipa/freeipa/pull/7821

Do we need a complicated xfail now? Aren't the releases currently coherent with what the OS-provided (fips-mode-setup) and ipa-healthcheck? If not then it seems like this is a healthcheck bug to fix.

master:

  • 982569fcb3d23d6e6578e5efbaafb99c32542a8d ipatests: fix xfail annotation for test_ipa_healthcheck_fips_enabled

ipa-4-12:

  • 8653c48bd2550063c404cca80453ef6392e0fddc ipatests: fix xfail annotation for test_ipa_healthcheck_fips_enabled

Metadata Update from @frenaud:
- Issue close_status updated to: fixed
- Issue status updated to: Closed (was: Open)

Metadata