#9740 Suppress meaningless errors when uninstalling the PKI ACME service
Closed: fixed by rcritten. Opened by rcritten.

Issue

ACME is uninstalled separately from PKI but has very course error handling so all we get is a pass/fail. This can lead to scary messages like:

failed to uninstall ACME instance CalledProcessError(Command ['pki-server', 'acme-remove'] returned non-zero exit status 1: 'ERROR: Invalid instance: pki-tomcat\nTraceback (most recent call last):\n File "/usr/lib/python3.12/site-packages/pki/server/pkiserver.py", line 41, in \n cli.execute(sys.argv)\n File "/usr/lib/python3.12/site-packages/pki/server/cli/init.py", line 144, in execute\n super().execute(args)\n File "/usr/lib/python3.12/site-packages/pki/cli/init.py", line 217, in execute\n module.execute(module_args)\n File "/usr/lib/python3.12/site-packages/pki/cli/init.py", line 217, in execute\n module.execute(module_args)\n File "/usr/lib/python3.12/site-packages/pki/server/cli/acme.py", line 211, in execute\n raise Exception(\'Invalid instance: %s\' % instance_name)\nException: Invalid instance: pki-tomcat\n')

Errors can also occur if there is no acme sub-directory in the pki-tomcat instance.

We should ignore and not report both of those.


The first is very easy to reproduce: run ipa-server-install --uninstall when the server is not installed.

The second is less common but I've definitely seen it. You can force reproduce it with:

ipa-server-install ...
pki-server undeploy-acme
rm -rf /etc/pki/pki-tomcat/acme
ipa-server-install --uninstall -U

PR https://github.com/freeipa/freeipa/pull/7676

master:

  • 18c4a2f9e32728765af3044b2c88fec033c43921 Suppress spurious failure messages when uninstalling ACME

Metadata Update from @rcritten:
- Issue close_status updated to: fixed
- Issue status updated to: Closed (was: Open)

ipa-4-12:

  • 826ba67e4b3237ccda081fa3f288d35a564f4890 Suppress spurious failure messages when uninstalling ACME
Metadata