#9637 adtrustinstance only prints issues in check_inst() and does not log them
Closed: fixed by frenaud. Opened by rcritten.

Issue

ipaserver/install/adtrustinstance.py provides the function check_inst() which ensures that the Samba packages are installed and that /usr/share/ipa/smb.conf.empty exists which means the adtrust sub-package is installed.

Unfortunately it only prints the output and does not log it making reviewing a user-provided log insufficient to know exactly what is wrong.

Steps to Reproduce

  1. Add --setup-adtrust to the ipa-server-install CLI without having the freeipa-server-trust-ad package installed

Actual behavior

AD Trust requires the 'freeipa-server-trust-ad' package
Please install the package and start the installation again
Aborting installation.

The server install log contains only "Aborting installation."

Expected behavior

The server log also contains the printed messsage.


Metadata Update from @rcritten:
- Issue assigned to rcritten

PR https://github.com/freeipa/freeipa/pull/7458

master:

  • 1dc84ba7ebf1bb3b2734a9ea0dd1a4ba6660c93b Log errors reported by adtrustinstance.check_inst() using logger

ipa-4-12:

  • e83d949c7f1734dff70379e360e9bbf626149c61 Log errors reported by adtrustinstance.check_inst() using logger

ipa-4-11:

  • f21ca0c6d4cc2e9f0185b655d3399e0857a14d1e Log errors reported by adtrustinstance.check_inst() using logger

Metadata Update from @frenaud:
- Issue close_status updated to: fixed
- Issue status updated to: Closed (was: Open)

Metadata Update from @frenaud:
- Custom field rhbz adjusted to https://issues.redhat.com/browse/RHEL-53501, https://issues.redhat.com/browse/RHEL-53500

Metadata