#9514 Make sure a default NetBIOS name is set if not passed in by ADTrust instance constructor
Closed: fixed by frenaud. Opened by abbra.

we default the option netbios_name to None in /usr/libexec/ipa/oddjob/org.freeipa.server.config-enable-sid and do not get it defaulted to a value we generate if it is None. A workaround would be to pass the netbios name explicitly to the tool and a fix is to use make_netbios_name out of the realm if not passed:

# ipa -e in_server=True console
(Custom IPA interactive Python console)
    api: IPA API object
    pp: pretty printer
>>> from ipaserver.install.adtrustinstance import make_netbios_name
>>> make_netbios_name(api.env.realm)
'EXAMPLE'

This affects /usr/libexec/ipa/oddjob/org.freeipa.server.config-enable-sid specifically because it passes None as netbios_name to ADTrustInstance if not overidden.

PR: https://github.com/freeipa/freeipa/pull/7161

master:

  • 9b456101a3072cdf7f48dfdcfea1002d10d35597 adtrustinstance: make sure NetBIOS name defaults are set properly

Metadata Update from @frenaud:
- Custom field on_review adjusted to https://github.com/freeipa/freeipa/pull/7161
- Custom field rhbz adjusted to https://issues.redhat.com/browse/RHEL-21938, https://issues.redhat.com/browse/RHEL-21937

ipa-4-11:

  • eab52d3cda9bbec716008c040551bd11facd0e11 adtrustinstance: make sure NetBIOS name defaults are set properly

ipa-4-10:

  • 3baa30ad3f6ee563089839a5ef56d5ac6eb43959 adtrustinstance: make sure NetBIOS name defaults are set properly

ipa-4-9:

  • 2f17319df6147832dceff7c06154363f8d58b194 adtrustinstance: make sure NetBIOS name defaults are set properly

Metadata Update from @frenaud:
- Issue close_status updated to: fixed
- Issue status updated to: Closed (was: Open)

Metadata