#9366 Covscan issue: Dereferencing null pointer "pac"
Closed: wontfix by abbra. Opened by rjeffman.

Covscan has detected the following Derreference NULL pointer issues:

 7. freeipa-4.9.11/daemons/ipa-kdb/ipa_kdb_mspac.c:2350: var_compare_op: Comparing "pac" to null implies that "pac" might be null.
8. freeipa-4.9.11/daemons/ipa-kdb/ipa_kdb_mspac.c:2359: var_deref_op: Dereferencing null pointer "pac".
#  2357|           }
#  2358|       } else {
#  2359|->         new_pac = *pac;
#  2360|       }
#  2361|   
 16. freeipa-4.9.11/daemons/ipa-kdb/ipa_kdb_mspac.c:1116: var_compare_op: Comparing "pac" to null implies that "pac" might be null.
17. freeipa-4.9.11/daemons/ipa-kdb/ipa_kdb_mspac.c:1127: var_deref_op: Dereferencing null pointer "pac".
#  1125|       data.length = pac_data.length;
#  1126|   
#  1127|->     kerr = krb5_pac_add_buffer(kcontext, *pac, KRB5_PAC_LOGON_INFO, &data);
#  1128|   
#  1129|       /* == Package UPN_DNS_LOGON_INFO == */

this is false positive. We support two users for this function:
- one passes pac pointer pointing to NULL, e.g. asking us to allocate the PAC structure
- the other passes pac pointer with preallocated buffer

Metadata Update from @abbra:
- Issue close_status updated to: wontfix
- Issue status updated to: Closed (was: Open)

Metadata