Recently released pylint 2.8 fails against IPA code with:
************* Module makeapi makeapi:246: [R1732(consider-using-with), make_api] Consider using 'with' for resource-allocating operations) makeapi:329: [R1732(consider-using-with), validate_api] Consider using 'with' for resource-allocating operations) ************* Module ipatests.test_xmlrpc.test_automount_plugin ipatests/test_xmlrpc/test_automount_plugin.py:83: [R1732(consider-using-with), AutomountTest.check_import_roundtrip] Consider using 'with' for resource-allocating operations) ************* Module ipatests.test_ipaserver.test_install.test_installutils ipatests/test_ipaserver/test_install/test_installutils.py:50: [R1732(consider-using-with), gpgkey] Consider using 'with' for resource-allocating operations) ************* Module ipatests.test_integration.test_trust ipatests/test_integration/test_trust.py:426: [E1101(no-member), TestTrust.test_subordinate_suffix] Instance of '__class_getitem__' has no 'run_command' member) ipatests/test_integration/test_trust.py:435: [E1101(no-member), TestTrust.test_subordinate_suffix] Instance of '__class_getitem__' has no 'run_command' member) ipatests/test_integration/test_trust.py:450: [E1101(no-member), TestTrust.test_subordinate_suffix] Instance of '__class_getitem__' has no 'run_command' member) ipatests/test_integration/test_trust.py:469: [E1101(no-member), TestTrust.test_subordinate_suffix] Instance of '__class_getitem__' has no 'run_command' member) ipatests/test_integration/test_trust.py:787: [E1101(no-member), TestTrust.test_establish_forest_trust_with_shared_secret] Instance of '__class_getitem__' has no 'run_command' member) ipatests/test_integration/test_trust.py:796: [E1101(no-member), TestTrust.test_trustdomains_found_in_forest_trust_with_shared_secret] Instance of '__class_getitem__' has no 'domain' member) ipatests/test_integration/test_trust.py:828: [E1101(no-member), TestTrust.test_remove_forest_trust_with_shared_secret] Instance of '__class_getitem__' has no 'run_command' member) ipatests/test_integration/test_trust.py:850: [E1101(no-member), TestTrust.test_establish_external_trust_with_shared_secret] Instance of '__class_getitem__' has no 'run_command' member) ipatests/test_integration/test_trust.py:852: [E1101(no-member), TestTrust.test_establish_external_trust_with_shared_secret] Instance of '__class_getitem__' has no 'domain' member) ipatests/test_integration/test_trust.py:863: [E1101(no-member), TestTrust.test_trustdomains_found_in_external_trust_with_shared_secret] Instance of '__class_getitem__' has no 'domain' member) ipatests/test_integration/test_trust.py:890: [E1101(no-member), TestTrust.test_remove_external_trust_with_shared_secret] Instance of '__class_getitem__' has no 'run_command' member) ipatests/test_integration/test_trust.py:892: [E1101(no-member), TestTrust.test_remove_external_trust_with_shared_secret] Instance of '__class_getitem__' has no 'domain' member) ipatests/test_integration/test_trust.py:935: [E1101(no-member), TestTrust.test_server_option_with_unreachable_ad] Instance of '__class_getitem__' has no 'ip' member) ipatests/test_integration/test_trust.py:936: [E1101(no-member), TestTrust.test_server_option_with_unreachable_ad] Instance of '__class_getitem__' has no 'hostname' member) ipatests/test_integration/test_trust.py:936: [E1101(no-member), TestTrust.test_server_option_with_unreachable_ad] Instance of '__class_getitem__' has no 'domain' member) ipatests/test_integration/test_trust.py:937: [E1101(no-member), TestTrust.test_server_option_with_unreachable_ad] Instance of '__class_getitem__' has no 'shortname' member) ipatests/test_integration/test_trust.py:969: [E1101(no-member), TestTrust.test_server_option_with_unreachable_ad] Instance of '__class_getitem__' has no 'hostname' member) ipatests/test_integration/test_trust.py:974: [E1101(no-member), TestTrust.test_server_option_with_unreachable_ad] Instance of '__class_getitem__' has no 'domain' member) ipatests/test_integration/test_trust.py:982: [E1101(no-member), TestTrust.test_server_option_with_unreachable_ad] Instance of '__class_getitem__' has no 'domain' member) ipatests/test_integration/test_trust.py:983: [E1101(no-member), TestTrust.test_server_option_with_unreachable_ad] Instance of '__class_getitem__' has no 'hostname' member) ************* Module ipatests.test_cmdline.test_cli ipatests/test_cmdline/test_cli.py:338: [R1732(consider-using-with), test_cli_fsencoding] Consider using 'with' for resource-allocating operations) ipatests/test_cmdline/test_cli.py:403: [R1732(consider-using-with), test_command_ipa_not_installed] Consider using 'with' for resource-allocating operations) ************* Module ipatests.pytest_ipa.integration.create_caless_pki ipatests/pytest_ipa/integration/create_caless_pki.py:360: [R1732(consider-using-with), revoke_cert] Consider using 'with' for resource-allocating operations) ************* Module ipatests.pytest_ipa.integration.tasks ipatests/pytest_ipa/integration/tasks.py:2706: [R1732(consider-using-with), run_ssh_cmd] Consider using 'with' for resource-allocating operations) ************* Module ipaserver.install.ipactl ipaserver/install/ipactl.py:89: [R1732(consider-using-with), is_dirsrv_debugging_enabled] Consider using 'with' for resource-allocating operations) ipaserver/install/ipactl.py:319: [R1732(consider-using-with), get_config_from_file] Consider using 'with' for resource-allocating operations) ************* Module ipaserver.install.ldapupdate ipaserver/install/ldapupdate.py:322: [R1732(consider-using-with), LDAPUpdate.read_file] Consider using 'with' for resource-allocating operations) ************* Module ipaserver.install.opendnssecinstance ipaserver/install/opendnssecinstance.py:148: [R1732(consider-using-with), OpenDNSSECInstance.__setup_conf_files] Consider using 'with' for resource-allocating operations) ipaserver/install/opendnssecinstance.py:165: [R1732(consider-using-with), OpenDNSSECInstance.__setup_conf_files] Consider using 'with' for resource-allocating operations) ipaserver/install/opendnssecinstance.py:174: [R1732(consider-using-with), OpenDNSSECInstance.__setup_conf_files] Consider using 'with' for resource-allocating operations) ************* Module ipaserver.install.adtrustinstance ipaserver/install/adtrustinstance.py:89: [R1732(consider-using-with), ipa_smb_conf_exists] Consider using 'with' for resource-allocating operations) ipaserver/install/adtrustinstance.py:633: [R1732(consider-using-with), ADTRUSTInstance.__update_krb5_conf] Consider using 'with' for resource-allocating operations) ************* Module ipaserver.install.httpinstance ipaserver/install/httpinstance.py:200: [R1732(consider-using-with), HTTPInstance.__configure_http] Consider using 'with' for resource-allocating operations) ipaserver/install/httpinstance.py:211: [R1732(consider-using-with), HTTPInstance.__configure_http] Consider using 'with' for resource-allocating operations) ************* Module ipaserver.install.installutils ipaserver/install/installutils.py:262: [R1732(consider-using-with), add_record_to_hosts] Consider using 'with' for resource-allocating operations) ipaserver/install/installutils.py:952: [R1732(consider-using-with), load_pkcs12] Consider using 'with' for resource-allocating operations) ipaserver/install/installutils.py:1194: [R1732(consider-using-with), load_external_cert] Consider using 'with' for resource-allocating operations) ipaserver/install/installutils.py:1198: [R1732(consider-using-with), load_external_cert] Consider using 'with' for resource-allocating operations) ************* Module ipapython.dn ipapython/dn.py:448: [R1731(consider-using-max-builtin), _adjust_indices] Consider using 'end = max(end, 0)' instead of unnecessary if block) ipapython/dn.py:453: [R1731(consider-using-max-builtin), _adjust_indices] Consider using 'start = max(start, 0)' instead of unnecessary if block) ************* Module ipaserver.install.cainstance ipaserver/install/cainstance.py:107: [R1732(consider-using-with), get_preop_pin] Consider using 'with' for resource-allocating operations) ipaserver/install/cainstance.py:580: [R1732(consider-using-with), CAInstance.__spawn_instance] Consider using 'with' for resource-allocating operations) ipaserver/install/cainstance.py:834: [R1732(consider-using-with), CAInstance.__request_ra_certificate] Consider using 'with' for resource-allocating operations) ipaserver/install/cainstance.py:850: [R1732(consider-using-with), CAInstance.__request_ra_certificate] Consider using 'with' for resource-allocating operations) ipaserver/install/cainstance.py:855: [R1732(consider-using-with), CAInstance.__request_ra_certificate] Consider using 'with' for resource-allocating operations) ************* Module ipapython.ipautil ipapython/ipautil.py:330: [R1732(consider-using-with), write_tmp_file] Consider using 'with' for resource-allocating operations) ipapython/ipautil.py:487: [R1732(consider-using-with), run] Consider using 'with' for resource-allocating operations) ipapython/ipautil.py:534: [R1732(consider-using-with), run] Consider using 'with' for resource-allocating operations) ************* Module ipaserver.install.server.upgrade ipaserver/install/server/upgrade.py:131: [R1732(consider-using-with), update_conf] Consider using 'with' for resource-allocating operations) ipaserver/install/server/upgrade.py:232: [R1732(consider-using-with), update_dbmodules] Consider using 'with' for resource-allocating operations) ipaserver/install/server/upgrade.py:261: [R1732(consider-using-with), update_dbmodules] Consider using 'with' for resource-allocating operations) ************* Module ipaplatform.debian.tasks ipaplatform/debian/tasks.py:152: [R1732(consider-using-with), DebianTaskNamespace.write_ca_certificates_dir] Consider using 'with' for resource-allocating operations) ************* Module ipaplatform.redhat.tasks ipaplatform/redhat/tasks.py:316: [R1732(consider-using-with), RedHatTaskNamespace.write_p11kit_certs] Consider using 'with' for resource-allocating operations) ************* Module ipalib.util ipalib/util.py:220: [R1732(consider-using-with), check_writable_file] Consider using 'with' for resource-allocating operations) ipalib/util.py:1327: [R1732(consider-using-with), open_in_pager] Consider using 'with' for resource-allocating operations) ************* Module ipalib.install.certmonger ipalib/install/certmonger.py:124: [R1732(consider-using-with), _certmonger._start_private_conn] Consider using 'with' for resource-allocating operations) ************* Module ipaclient.plugins.automount ipaclient/plugins/automount.py:142: [R1732(consider-using-with), automountlocation_import.__read_mapfile] Consider using 'with' for resource-allocating operations) ************* Module test daemons/ipa-otpd/test.py:46: [R1732(consider-using-with), main] Consider using 'with' for resource-allocating operations) ************* Module ipa-replica-conncheck install/tools/ipa-replica-conncheck:72: [R1732(consider-using-with), SshExec.__call__] Consider using 'with' for resource-allocating operations) ************* Module ipaclient.install.client ipaclient/install/client.py:364: [R1732(consider-using-with), disable_ra] Consider using 'with' for resource-allocating operations) ipaclient/install/client.py:1055: [R1732(consider-using-with), change_ssh_config] Consider using 'with' for resource-allocating operations) ipaclient/install/client.py:1092: [R1732(consider-using-with), change_ssh_config] Consider using 'with' for resource-allocating operations) ipaclient/install/client.py:1604: [R1732(consider-using-with), update_ssh_keys] Consider using 'with' for resource-allocating operations) ----------------------------------- Your code has been rated at 9.99/10 make: *** [Makefile:1356: pylint] Error 10
PR: https://github.com/freeipa/freeipa/pull/5737
master:
ipa-4-8:
ipa-4-9:
Metadata Update from @rcritten: - Issue close_status updated to: fixed - Issue status updated to: Closed (was: Open)