freeipa

#8795 Remove dependency from tests on ipaserver package/modules
Opened by kaleem. Modified

Open
Close Issue

Request for enhancement

At the moment tests from test_integration are dependent on modules from freeipa/ipaserver package and following is the list of those tests . 

test_commands.py:from ipaserver.install.installutils import realm_to_serverid
test_commands.py:# from ipaserver.masters
test_ipahealthcheck.py:from ipaserver.install.installutils import resolve_ip_addresses_nss
test_upgrade.py:from ipaserver.install import bindinstance
test_upgrade.py:from ipaserver.install.sysupgrade import STATEFILE_FILE
test_upgrade.py:                "from ipaserver.install import krainstance; "
test_installation.py:from ipaserver.install import krainstance
test_uninstallation.py:# from ipaserver.install.dsinstance
test_acme.py:from ipaserver.install import cainstance

Affected tests should be modified because of removal of this dependency on ipaserver modules/packages.

This is partly intersects with https://pagure.io/freeipa/issue/8766

@kaleem what is the motivation for removing ipaserver imports from ipatests?

I'd also add lib389 dependency, because of the same reasons.
@rcritten we have issues with running these tests downstream. The plan is not to remove the imports per se, but rather to move required code to other, better accessible location.

Metadata Update from @mpolovka:
- Issue assigned to mpolovka

Metadata Update from @mpolovka:
- Issue tagged with: rfe, tests

This doesn't explain why ipaserver cannot be imported.

One of reasons can be seen in https://pagure.io/freeipa/issue/8620 where we have a real trouble running mixed OS configurations for test controller/test executor.

I guess my point is that the text of the ticket lacks any of this reasoning. It just says what must be done but not why ipaserver cannot be imported. If other packages (ipapython, ipalib, etc) can be imported then please explain why ipaserver cannot. I can see why 8620 might be relevant to this use-case but none of the things modified there are mentioned in the initial text AFAICT.

@rcritten I must also admit I am not sure as to why remove ipaserver dependency. R
I've found out, that in order to remove external dependency on lib389 and move relevant parts of the code into common accessible place, I would have to copy-paste and re-resolve about 24 separate files. These files, however, would have to be manually kept in sync with lib389 package, which would again create lot of work. Thus, I've decided to copy-paste one dictionary on which one of the tests truly depends.
I think we should properly discuss removing ipaserver dependency, because such extensive dependency resolution won't be easy. Unless something eludes me.
Edited by mpolovka

Metadata Update from @mpolovka:
- Issue untagged with: rfe

master:

  • 3189e501fb1cb88db1cbdf8db7d8dd95759b7add ipatests: test_installation: move tracking_reqs dependency to ipalib constants ipaserver: krainstance: utilize moved tracking_reqs dependency

ipa-4-9:

  • e5df4dc4884f1a66ccbca79b9a0d83874c996d1d ipatests: test_installation: move tracking_reqs dependency to ipalib constants ipaserver: krainstance: utilize moved tracking_reqs dependency
Metadata

tests

None
None
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.