#8766 [pylint] broken configuration of ipa-forbidden-import checker
Opened by slev. Modified

Current configuration of ipa-forbidden-import checker:

[IPA]
forbidden-imports=
    client/:ipaserver,
    ipaclient/:ipaclient.install:ipalib.install:ipaserver,
    ipaclient/install/:ipaserver,
    ipalib/:ipaclient.install:ipalib.install:ipaserver,
    ipalib/install/:ipaserver,
    ipaplatform/:ipaclient:ipalib:ipaserver,
    ipapython/:ipaclient:ipalib:ipaserver
    ipatests/pytest_ipa:ipaserver:ipaclient.install:ipalib.install
    ipatests/test_integration:ipaserver

The config entry separator is comma sign. The missing separator leads to unexpected results. Adding this back expose several Pylint errors:

************* Module ipatests.test_integration.test_upgrade
ipatests/test_integration/test_upgrade.py:20: [W9901(ipa-forbidden-import), ] Forbidden import ipaserver.install.bindinstance (can't import from ipaserver in ipatests/test_integration))
ipatests/test_integration/test_upgrade.py:21: [W9901(ipa-forbidden-import), ] Forbidden import ipaserver.install.sysupgrade.STATEFILE_FILE (can't import from ipaserver in ipatests/test_integration))
************* Module ipatests.test_integration.test_ipahealthcheck
ipatests/test_integration/test_ipahealthcheck.py:25: [W9901(ipa-forbidden-import), ] Forbidden import ipaserver.install.installutils.resolve_ip_addresses_nss (can't import from ipaserver in ipatests/test_integration))
************* Module ipatests.test_integration.test_installation
ipatests/test_integration/test_installation.py:37: [W9901(ipa-forbidden-import), ] Forbidden import ipaserver.install.krainstance (can't import from ipaserver in ipatests/test_integration))
************* Module ipatests.test_integration.test_commands
ipatests/test_integration/test_commands.py:41: [W9901(ipa-forbidden-import), ] Forbidden import ipaserver.install.installutils.realm_to_serverid (can't import from ipaserver in ipatests/test_integration))
************* Module ipatests.test_integration.test_acme
ipatests/test_integration/test_acme.py:17: [W9901(ipa-forbidden-import), ] Forbidden import ipaserver.install.cainstance (can't import from ipaserver in ipatests/test_integration))

will be fixed in https://github.com/freeipa/freeipa/pull/5656

Metadata