#8143 service.ldap_disable() does not remove "enabledService"
Closed: fixed by cheimes. Opened by cheimes.

service.ldap_disable() does not disable services because it has a comparison bug. It compares value.lower() == ENABLED_SERVICE but ENABLED_SERVICE is defined as string 'enabledService'. The comparison never matches and enabledService is never removed from ipaConfigString. https://github.com/freeipa/freeipa/blob/836b90f65244a0407e74627b550297d0962d882e/ipaserver/install/service.py#L692-L696

The bug does not cause any problems at the moment. service.ldap_disable() is only used in DNSSEC code. The _disable_dnssec() helper first disables the DNSSEC and DNSKeyExporter services, then removes the entire LDAP entry for both services.


Metadata Update from @cheimes:
- Custom field on_review adjusted to https://github.com/freeipa/freeipa/pull/4005
- Issue assigned to cheimes

master:

  • 3cae7f4ee6fbfed99930a87e78d7e37bdb740e43 Fix service ldap_disable()

ipa-4-8:

  • b39ee3e1721b6d8234dd209343a8b01dbeaf3d3a Fix service ldap_disable()

Metadata Update from @cheimes:
- Issue close_status updated to: fixed
- Issue status updated to: Closed (was: Open)

Metadata