#7772 pylint 2.2.0 violations
Closed: fixed Opened by cheimes.

pylint 2.2.0 was released. The latest version detects a bunch of additional problems in our code base.

Pylint on /usr/bin/python3 is running, please wait ...
************* Module ipaclient.plugins.rpcclient
ipaclient/plugins/rpcclient.py:42: [W0107(unnecessary-pass), rpcclient] Unnecessary pass statement)
ipaclient/plugins/rpcclient.py:49: [W0107(unnecessary-pass), rpcclient] Unnecessary pass statement)
************* Module ipapython.admintool
ipapython/admintool.py:215: [W0107(unnecessary-pass), AdminTool.ask_for_options] Unnecessary pass statement)
************* Module ssl_test
ssl_test.py:10: [C0305(trailing-newlines), ] Trailing newlines)
************* Module ipapython.certdb
ipapython/certdb.py:227: [W0107(unnecessary-pass), Pkcs12ImportIncorrectPasswordError] Unnecessary pass statement)
ipapython/certdb.py:233: [W0107(unnecessary-pass), Pkcs12ImportOpenError] Unnecessary pass statement)
ipapython/certdb.py:239: [W0107(unnecessary-pass), Pkcs12ImportUnknownError] Unnecessary pass statement)
************* Module ipa-csreplica-manage
install/tools/ipa-csreplica-manage:73: [W1655(dict-keys-not-iterating), parse_options] dict.keys referenced when not iterating)
************* Module ipa-httpd-kdcproxy
install/tools/ipa-httpd-kdcproxy:186: [R1710(inconsistent-return-statements), main] Either all return statements in a function should return an expression, or none of them should.)
************* Module ipa-replica-conncheck
install/tools/ipa-replica-conncheck:418: [R1710(inconsistent-return-statements), main] Either all return statements in a function should return an expression, or none of them should.)
************* Module ipa-ca-install
install/tools/ipa-ca-install:187: [E1101(no-member), install_replica] Module 'ipaserver.install.service' has no 'find_providing_server' member)
install/tools/ipa-ca-install:261: [E1101(no-member), install] Module 'ipaserver.install.service' has no 'find_providing_server' member)
************* Module ipaplatform.redhat.authconfig
ipaplatform/redhat/authconfig.py:59: [W0107(unnecessary-pass), RedHatAuthToolBase.backup] Unnecessary pass statement)
ipaplatform/redhat/authconfig.py:67: [W0107(unnecessary-pass), RedHatAuthToolBase.restore] Unnecessary pass statement)
************* Module ipaplatform.base.tasks
ipaplatform/base/tasks.py:180: [W0107(unnecessary-pass), BaseTaskNamespace.migrate_auth_configuration] Unnecessary pass statement)
************* Module ipa-replica-manage
install/tools/ipa-replica-manage:114: [W1655(dict-keys-not-iterating), parse_options] dict.keys referenced when not iterating)
install/tools/ipa-replica-manage:435: [W1655(dict-keys-not-iterating), get_ruv_both_suffixes] dict.keys referenced when not iterating)
install/tools/ipa-replica-manage:468: [R1710(inconsistent-return-statements), get_rid_by_host] Either all return statements in a function should return an expression, or none of them should.)
install/tools/ipa-replica-manage:720: [R1718(consider-using-set-comprehension), clean_dangling_ruvs] Consider using a set comprehension)
install/tools/ipa-replica-manage:725: [R1718(consider-using-set-comprehension), clean_dangling_ruvs] Consider using a set comprehension)
************* Module ipalib.plugable
ipalib/plugable.py:233: [W0107(unnecessary-pass), Plugin._on_finalize] Unnecessary pass statement)
************* Module ipatests.pytest_ipa.integration.tasks
ipatests/pytest_ipa/integration/tasks.py:528: [W0107(unnecessary-pass), configure_dns_for_trust] Unnecessary pass statement)
************* Module ipatests.test_webui.test_config
ipatests/test_webui/test_config.py:87: [W1308(duplicate-string-formatting-argument), test_config.verify_user_cfg_change] Duplicate string formatting argument 'field', consider passing as named argument)
ipatests/test_webui/test_config.py:89: [W1308(duplicate-string-formatting-argument), test_config.verify_user_cfg_change] Duplicate string formatting argument 'field', consider passing as named argument)
************* Module ipatests.test_integration.test_installation
ipatests/test_integration/test_installation.py:329: [W0107(unnecessary-pass), TestADTrustInstall] Unnecessary pass statement)
************* Module ipatests.test_xmlrpc.tracker.base
ipatests/test_xmlrpc/tracker/base.py:395: [W0107(unnecessary-pass), Tracker] Unnecessary pass statement)
************* Module ipaserver.servroles
ipaserver/servroles.py:142: [W0107(unnecessary-pass), BaseServerRole.create_search_params] Unnecessary pass statement)
ipaserver/servroles.py:153: [W0107(unnecessary-pass), BaseServerRole.get_result_from_entries] Unnecessary pass statement)
************* Module ipaserver.dcerpc
ipaserver/dcerpc.py:160: [W0107(unnecessary-pass), TrustTopologyConflictSolved] Unnecessary pass statement)
************* Module ipaserver.p11helper
ipaserver/p11helper.py:524: [W0107(unnecessary-pass), P11HelperException] Unnecessary pass statement)
ipaserver/p11helper.py:530: [W0107(unnecessary-pass), Error] Unnecessary pass statement)
ipaserver/p11helper.py:535: [W0107(unnecessary-pass), NotFound] Unnecessary pass statement)
ipaserver/p11helper.py:540: [W0107(unnecessary-pass), DuplicationError] Unnecessary pass statement)
************* Module ipaserver.install.adtrustinstance
ipaserver/install/adtrustinstance.py:566: [W0107(unnecessary-pass), ADTRUSTInstance.set_keytab_owner] Unnecessary pass statement)
************* Module ipa-dnskeysync-replica
daemons/dnssec/ipa-dnskeysync-replica:53: [R1710(inconsistent-return-statements), find_unwrapping_key] Either all return statements in a function should return an expression, or none of them should.)

Metadata Update from @cheimes:
- Issue assigned to cheimes

Metadata Update from @cheimes:
- Issue priority set to: critical
- Issue set to the milestone: FreeIPA 4.7.2

master:

  • 533a5b2633e8b5d9049256ea085324cbc45c6e73 pylint 2.2: Fix unnecessary pass statement
  • f800d8f8cab90dd23547c1da790ec2af69d3614a pylint: Fix duplicate-string-formatting-argument
  • d8791f8f9b7fda3ad8a27120a3cf86ee90cdd353 pylint: also verify scripts
  • bb4b558164d4f33ca09b9c2b2fbeb0de3280e00b Address misc pylint issues in CLI scripts

ipa-4-7:

  • bc3e24c1725a429422481655d72e80e0dad62456 pylint 2.2: Fix unnecessary pass statement
  • 0ae08969c16ea51784517dec5dee8c54dc416a90 pylint: Fix duplicate-string-formatting-argument
  • f991319da03fbdec442fe55a06086cf8485d642e pylint: also verify scripts
  • fa78de9ae2db865dbe9f9f8f6a7a48472b73c32d Address misc pylint issues in CLI scripts

Metadata Update from @tdudlak:
- Issue close_status updated to: fixed
- Issue status updated to: Closed (was: Open)

ipa-4-6:

  • cb21a71e13c629faf63ebe96a143621c16b4b087 pylint 2.2: Fix unnecessary pass statement
  • 905b40256f3527d2d8f9175ba11bcd4418638c80 pylint: Fix duplicate-string-formatting-argument
  • fa9affae0d5112d10b62aa956db78c43699ae1e1 pylint: also verify scripts
  • e959d1472052a1d576af807f62234820234382f8 Address misc pylint issues in CLI scripts
  • b7de732fd89f2df7a5838b68eff1601990901002 Address pylint violations in lite-server
  • 2ecad905c0c7f226fe7986ee2401be6a7927e7dd Address inconsistent-return-statements
  • 7b090ba382e96c9fd8075e10457f2f9e8aacd141 Fix Module 'pytest' has no 'config' member
  • 2a5114f6000cc37cff3904f229510ee5417fce93 Silence comparison-with-itself in tests
  • 42eae483e15a243a6ba1d9e9f7f828b273a3461d Ignore W504 code style like in travis config
  • 8753e2f0f9b85681e162baa3681754f6f46df0d1 Ignore consider-using-enumerate for now
  • 8185ebc734ce85ca57fc62339c00866b03ca0195 Address consider-using-in
  • 2fd773d2ff4bf60b6330f6b31a32de5d2ef7f003 Fix comparison-with-callable
  • 33a94d06647180596ec853555e3b45ef45a952dd Fix useless-import-alias
Metadata