#7738 Fix C issues found by coverity and other tools
Closed: fixed Opened by twoerner.

Internal tests with coverity and other tools have revealed some issues in the freeipa C code. These will be addressed with this ticket.


Metadata Update from @twoerner:
- Issue assigned to twoerner

Here is the pull request: https://github.com/freeipa/freeipa/pull/2469

master:

  • 389c17c5c6656027fcece6ddd4322e4e64f17ff6 Fix ressource leak in client/config.c get_config_entry
  • 8e98c72e5186d099eb4ac0d8b059c4fce64fd739 Fix ressource leak in daemons/ipa-slapi-plugins/ipa-cldap/ipa_cldap_netlogon.c ipa_cldap_netlogon

ipa-4-5:

  • 334d113c02d8a8cfb8dd83cc30b5759b7f185a55 Fix ressource leak in client/config.c get_config_entry
  • b1dc05bc35d00022253c5a31e5a14b4e10bd4ea8 Fix ressource leak in daemons/ipa-slapi-plugins/ipa-cldap/ipa_cldap_netlogon.c ipa_cldap_netlogon

ipa-4-6:

  • 416c9c5f688b70a34b5630d68ca57ebbda18a00c Fix ressource leak in client/config.c get_config_entry
  • 9756d4f913873053971104f074490ea1c01158df Fix ressource leak in daemons/ipa-slapi-plugins/ipa-cldap/ipa_cldap_netlogon.c ipa_cldap_netlogon

master:

  • 836e29591c2ea08c2fdf334c7095d36fe965f0f3 Fix ipadb_multires resource handling
  • 5fe3198d808346dfb36a45c89784f0e3214a88f1 Don't abuse strncpy() length limitation

ipa-4-7:

  • 705e280eafb13b1b55fc0b91001e4721ce79fbdf Fix ressource leak in client/config.c get_config_entry
  • ebb14ed6f57c5504dc2f44339274b108483efd16 Fix ressource leak in daemons/ipa-slapi-plugins/ipa-cldap/ipa_cldap_netlogon.c ipa_cldap_netlogon

ipa-4-6:

  • 8f369512c91b9ffb92152e23ba6e99098177f022 Fix ipadb_multires resource handling
  • 3e8a9424315be525458d3be6914ea6a8669a954a Don't abuse strncpy() length limitation

ipa-4-7:

  • 305150416429b85d46ad4162bac492db303cf9cf Fix ipadb_multires resource handling
  • 4ca3120b9a09ad48866446af29b38ca7c005b0d0 Don't abuse strncpy() length limitation

master:

  • aa261ba5b1c7594b3314fb606d46ec51f29f31a7 has_krbprincipalkey: avoid double free
  • 800e448aeb86acb06f714027fe70b5af9edfc8b2 ipadb_mspac_get_trusted_domains: NULL ptr deref
  • da2078bc6075b69a7bb52e18ab68cea4e1ecd346 ipapwd_pre_mod: NULL ptr deref

ipa-4-6:

  • 1c24577521c466ea86a9dc13420481b2f79e1e61 has_krbprincipalkey: avoid double free
  • 55c86da99414b329c2ce28cd53e271dadda54900 ipadb_mspac_get_trusted_domains: NULL ptr deref
  • f5f52e3e6c8a622be526378ea557f9d6a87db211 ipapwd_pre_mod: NULL ptr deref

ipa-4-7:

  • a06fb8d0f7b7c6aba942186b93d87823398f5337 has_krbprincipalkey: avoid double free
  • 2884ab69babfd7d40f951ba814234ce4763b0cd8 ipadb_mspac_get_trusted_domains: NULL ptr deref
  • 28b89df5ed8a9a060227433e8eeebf7eea844bb9 ipapwd_pre_mod: NULL ptr deref

Metadata Update from @twoerner:
- Issue close_status updated to: fixed
- Issue status updated to: Closed (was: Open)

Metadata