#7606 ValidationError dialog during addition of negative value for search size limit config
Closed: fixed Opened by ksiddiqu.

Issue

While testing negative value for 'search size limit' config option , now a validation error dialog box is shown(not-working.png), earlier it was just a hint down the text box in red colors (working.png)

Steps to Reproduce

  1. Login to web ui of IPA server.
  2. Go to IPA Server -> Configuration
  3. Enter -10 as value for "Search size limit" text box and click on 'save' button above the text box.

Actual behavior

A error dialog box is shown with validation error. (not-working.png)

Expected behavior

error should be part of hint down the text box which was there earlier (working.png)

Version/Release/Distribution

$ rpm -q freeipa-server freeipa-client ipa-server ipa-client 389-ds-base pki-ca krb5-server
[root@dhcp207-43 ~]# rpm -q freeipa-server freeipa-client ipa-server ipa-client 389-ds-base pki-ca krb5-server
freeipa-server-4.6.90test-0.fc28.x86_64
freeipa-client-4.6.90test-0.fc28.x86_64
package ipa-server is not installed
package ipa-client is not installed
389-ds-base-1.4.0.10-2.fc28.x86_64
pki-ca-10.6.2-1.fc28.noarch
krb5-server-1.16.1-7.fc28.x86_64
[root@dhcp207-43 ~]#

This version of freeipa-server i got from PR CI results .
http://freeipa-org-pr-ci.s3-website.eu-central-1.amazonaws.com/jobs/25e477ec-78ca-11e8-a040-fa163ed5c549/
http://freeipa-org-pr-ci.s3-website.eu-central-1.amazonaws.com/jobs/25e477ec-78ca-11e8-a040-fa163ed5c549/installed_packages/

Additional info:

Please find the attach images .
not-working.png
working.png


This behavior change is linked to commit e8d308196bab1dac5bba7a8a6a517a1e67e877f ipaserver config plugin: Increase search records minimum limit

Where did you get the build? The version number doesn't tell us when the build was created and which commits are in the build. It makes it hard to tell which commit caused the issue.

As @frenaud said, the behavior changed after 59e0c02fbd16135b91f5c1cb1bbf5e1180ad1322, trying to fix #6617, changing the minimum valid value to 10, but accepting -1 or 0.

My guess is that Web UI probably requires the minvalue argument to display the hint, that was removed in favor of a validation function.

If we set the minvalue to 10 then will be impossible to set -1 or 0, but if we set the minvalue back to -1 then the alert box will appear for values between 0 and 10, but not for values lower than -1, as expected.

Build info part of the description. Pasting one more time here.

This version of freeipa-server i got from PR CI results .
http://freeipa-org-pr-ci.s3-website.eu-central-1.amazonaws.com/jobs/25e477ec-78ca-11e8-a040-fa163ed5c549/
http://freeipa-org-pr-ci.s3-website.eu-central-1.amazonaws.com/jobs/25e477ec-78ca-11e8-a040-fa163ed5c549/installed_packages/

master:

  • e140d198eaf6982a966b2d0bf3edbd091142a894 ui_tests: stabilization fixes
  • 79391ad8e1e15af14b86167fb110c139d291a0a0 ui_tests: fix test_config::test_size_limits

Metadata Update from @cheimes:
- Issue close_status updated to: fixed
- Issue status updated to: Closed (was: Open)

ipa-4-6:

  • 2977535e7d47db9f15548de3972485e95bbfd0c5 ui_tests: fix test_config::test_size_limits
Metadata