#7452 Processing of server roles should ignore errors.EmptyResult
Closed: fixed by rcritten. Opened by abbra.

When non-admin user issues a command that utilizes api.Object.config.show_servroles_attributes(), some server roles might return errors.EmptyResult, indicating that a role is not visible to this identity.

Most of the callers to api.Object.config.show_servroles_attributes() do not process errors.EmptyResult so it goes up to an API caller. In case of Web UI it breaks retrieval of the initial configuration due to ipa config-show failing completely rather than avoiding to show available server roles.


Metadata Update from @abbra:
- Issue assigned to abbra

Found by Fedora 28 beta testing: https://bugzilla.redhat.com/show_bug.cgi?id=1557609

Metadata Update from @abbra:
- Custom field rhbz adjusted to https://bugzilla.redhat.com/show_bug.cgi?id=1557609

Metadata Update from @rcritten:
- Issue priority set to: critical
- Issue set to the milestone: FreeIPA 4.7

master:

  • 48acb7d86583c54296bc8334517989ce5a2199ea Processing of server roles should ignore errors.EmptyResult
  • 2da9a4ca6a060dea106f02269a961d9e6b8bebcf Update template directory with new variables when upgrading ipa.conf.template

Metadata Update from @tdudlak:
- Issue close_status updated to: fixed
- Issue status updated to: Closed (was: Open)

Tibor, did you verify that the fix is 4.7-only? I think the update_entry_with_role_config fix needs to land in 4.6 branch, too.

We also need a test for each of the bugs.

Metadata Update from @cheimes:
- Issue status updated to: Open (was: Closed)

No, i just looked at milestone.

Metadata Update from @cheimes:
- Issue priority set to: important (was: critical)
- Issue set to the milestone: FreeIPA 4.6.5 (was: FreeIPA 4.7)

Backport to ipa-4-6: https://github.com/freeipa/freeipa/pull/2858

ipa-4-6:

  • 56e55e040bad1d4485ad13dc28dd0537009078b5 Processing of server roles should ignore errors.EmptyResult
  • 0ad97028167705d44e9e64b43b312c516fbff7de Update template directory with new variables when upgrading ipa.conf.template

Metadata Update from @rcritten:
- Issue close_status updated to: fixed
- Issue status updated to: Closed (was: Open)

Metadata