fm-orchestrator

#440 Bug: module entered ready state even with failed build
Closed: Fixed Opened by ralph.

Closed: Fixed
Reopen Issue

See build 51 here: https://mbs.fedoraproject.org/module-build-service/1/module-builds/51

It entered the "ready" state even though the curl-7.53.1-1.module_60a31d5b component failed with state 3.

This should obviously not happen.

One thing to know about module build 51 is that it was a "re-submitted". @psabata submitted it once: 2 component builds failed and one was cancelled. He then re-submitted it. Lots of things happened, but it finally landed in this state.

For the record, the whole thing went like this:

  1. Module build 51 submitted and MBS starts building the ~175 components
  2. gc's test suite hangs and I ask Ralph to cancel the component build; MBS says there's 1 build in the cancelled state, some are building, some are complete and some are unspecified
  3. curl and diffutils fail to build but there are still some other components in the queue; MBS says there's 1 cancelled build, 2 failed, plenty of complete and some building/unspecified
  4. MBS finishes building, marks the build as failed and, somehow, changes the state of gc from cancelled to failed
  5. Module build 51 resubmitted; MBS says there are ~170 components building, 1 failed, 2 unspecified
  6. Nothing happens for a while; MBS is confused and we wait for the poller to sort it out
  7. MBS reuses all the ~170 successful builds
  8. MBS decides to build both the two unspecified builds (curl and diffutils) as well as the failed one (gc, originally cancelled)
  9. The gc build passes, yay; 2 more still building.
  10. diffutils pass, yay, curl still biulding.
  11. curl fails to build.
  12. MBS creates lots of tagBuild tasks that all fail; the components are tagged already.
  13. MBS changes the state of the module build 51 to ready.

Could this change in @jkaluza's PR be the fix?
https://pagure.io/fm-orchestrator/pull-request/437#_2,14-21

Metadata Update from @jkaluza:
- Issue assigned to jkaluza

This is the fix :) https://pagure.io/fm-orchestrator/pull-request/444

Metadata Update from @jkaluza:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/mbs/issues/440

Please continue any further discussion there.
Metadata
None
None
None
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.