From 189e534b47c51c5426be1d9a8ba7158597f36594 Mon Sep 17 00:00:00 2001 From: Mohan Boddu Date: Apr 06 2020 20:27:13 +0000 Subject: Adding test case for verifying if the reviewer is a packager Signed-off-by: Mohan Boddu --- diff --git a/tests/test_admin.py b/tests/test_admin.py index cc42969..73f7589 100644 --- a/tests/test_admin.py +++ b/tests/test_admin.py @@ -943,3 +943,32 @@ class FedScmAdmin(TestCase): 'sign.') assert error in result.output assert self.mock_git_obj.clone_repo.call_count == 0 + + @patch('fedscm_admin.utils.verify_slas', return_value=None) + @patch('fedscm_admin.request_utils.retry_session') + def test_fedscm_admin_process_master_wrong_bz_approver( + self, mock_retry_session, mock_slas): + """ + Tests fedscm-admin with the option "process" on a new repo request + for a repo requested by "akhairna" but the bug reviewed by "imposter" + """ + from fedscm_admin.fedscm_admin import cli as fedscm_admin_cli + from fedscm_admin import STANDARD_BRANCH_SLAS + + chosen_branch = get_latest_fedora_branch(STANDARD_BRANCH_SLAS) + mock_session = Mock() + mock_session.get.side_effect = [ + mock_values.get_mock_issue_rv(chosen_branch)] + mock_retry_session.return_value = mock_session + runner = CliRunner() + mock_path = 'fedscm_admin.FAS_CLIENT.user_member_of' + with patch(mock_path, return_value=False): + result = runner.invoke( + fedscm_admin_cli, ['process', '2'], + input='mprahl\n12345\nmprahl\n12345\nn\n') + assert result.exit_code == 0 + error = ('The Bugzilla bug\'s review ' + 'is approved by a user that is ' + 'not a packager') + assert error in result.output + assert self.mock_git_obj.clone_repo.call_count == 0