fedpkg

#548 Remove mbs.fedoraproject.org scopes from git cred helper
Merged by onosek. Opened by kjtsanaktsidis.
kjtsanaktsidis/fedpkg ktsanaktsidis/delete_mbs_scope  into  master

Download 548.patch

The fedpkg git credential helper defaults to asking for the
https://mbs.fedoraproject.org/oidc/submit-build scope in the
default config file. It seems that the mbs infrastructure has been torn
down and this scope is no longer valid:

https://pagure.io/fedora-infrastructure/issue/11990

And attempting to ask for it means that the credential helper fails
with:

Please visit https://id.fedoraproject.org/openidc/Authorization?scope=openid+https%3A%2F%2Fid.fedoraproject.org%2Fscope%2Fgroups+https%3A%2F%2Fmbs.fedoraproject.org%2Foidc%2Fsubmit-build+https%3A%2F%2Fsrc.fedoraproject.org%2Fpush&response_type=code&client_id=fedpkg&redirect_uri=http%3A%2F%2Flocalhost%3A12345%2F&response_mode=query to grant authorization
127.0.0.1 - - [14/Jun/2024 21:23:41] "GET /?error=invalid_scope&error_description=unknown+scope+https%3A%2F%2Fmbs.fedoraproject.org%2Foidc%2Fsubmit-build+requested HTTP/1.1" 200 47
No token received.
fatal: credential helper '/usr/bin/fedpkg gitcred' told us to quit
Could not execute push: Failed to execute command.

I'm not sure if the actual code for interfacing with the MBS should be
deleted out of rpkg or not, but certainly I think the default fedpkg
config file should work, so let's do this first?

Signed-off-by: KJ Tsanaktsidis kj@kjtsanaktsidis.id.au
romaingeissler1a commented

@onosek Do you have any opinion on this pull request ? (pinging you as you are the latest committer/releaser in this repo, and this issue still affects contributor using the http access since couple of weeks)

rebased onto af020e9ac9e77aa87a4e77453703139e8bb293ff

rebased onto ea4af44cf9d85de6e994bbd56f8645f32f9cc272

Pull-Request has been merged by onosek
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.