fedpkg

#543 (will be removed) added new request-unretirement command
Closed by amedvede. Opened by amedvede.
amedvede/fedpkg fedpkg_issue_509  into  master

Download 543.patch

This command will insure that the user filled all necessary information and will open a ticket with requests.

Signed-off-by: amedvede amedvede@redhat.com

1 new commit added

  • feat: added new args for request-unretirement

1 new commit added

  • feat: added getting proper namespace and repo name for request and getting proper branches list for request

1 new commit added

  • feat: added more description of command and added new logic of command

3 new commits added

  • feat: added checks that decide if bzurl is needed and checks if user in packager group
  • feat: added new util to get last commit date on specific branch
  • feat: added util to get user groups

1 new commit added

  • feat: fedora-review flag check added

3 new commits added

  • test: added test for new utills functions
  • feat: added required module to requirements file
  • feat: changed getting bugzilla flug to use existing module

Hello @amedvede . I looked at your change. I found a number of flake8 complaints in utils.py and cli.py. I would be able to fix them, but as the code is divided into 11 commits it would take some effort.
It is not needed to have so many commits within one feature. I think two or three main parts (including tests) would be OK. But if you insist on this division, please fix flake8 complaints and rebase your code with the head.
Otherwise, I will merge commits together (probably tests would go to the other one) and fix it by myself.
Thx.

rebased onto a270fc793e483135cb346fba97335a6e994d7dac

rebased onto a270fc793e483135cb346fba97335a6e994d7dac

@onosek I rebased those commits into one, its in following PR https://pagure.io/fedpkg/pull-request/558#

this PR can be removed and the conversation continued in a different one

@onosek hey, would you have a time to check new PR, it should be correct now

Pull-Request has been closed by amedvede
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.