#537 Remove pdc calls, use bodhi instead
Merged by onosek. Opened by lenkaseg.
lenkaseg/fedpkg pdc-retire  into  master

Download 537.patch

Since PDC is going to be dismissed, we need to redirect all pdc call to other APIs, for example bodhi.

Related to issue #535

Signed-off-by: Lenka Segura lsegura@redhat.com

Because the output of the bodhi API is different than the one from pdc, the get_stream_branches does not return list of dicts, but a list (of active releases).get_stream_branches now uses get_pagure_branches to get the package active branches
get_release_branches should keep returning the same as before, a dict.

rebased onto 3fa04767b4d090c0f440b28895450c4992729a7c

1 new commit added

  • Style changes

2 new commits added

  • Style changes
  • Remove pdc calls, use bodhi instead

1 new commit added

  • Remove function get_sl_type, no longer needed

3 new commits added

  • Remove function get_sl_type, no longer needed
  • Style changes
  • Remove pdc calls, use bodhi instead

1 new commit added

  • Remove traces of PDC in docstrings

Ready for review.

3 new commits added

  • Remove traces of PDC in docstrings
  • Remove function get_sl_type, no longer needed
  • Remove pdc calls, use bodhi instead

3 new commits added

  • Remove traces of PDC in docstrings
  • Remove function get_sl_type, no longer needed
  • Remove pdc calls, use bodhi instead

3 new commits added

  • Remove traces of PDC in docstrings
  • Remove function get_sl_type, no longer needed
  • Remove pdc calls, use bodhi instead

3 new commits added

  • Remove traces of PDC in docstrings
  • Remove function get_sl_type, no longer needed
  • Remove pdc calls, use bodhi instead

Finally flake8 gave up and let me be, phew!

rebased onto c27efc9492471b57cf50518a52e8661ad1d1e7d9

One little change added, no need to loop through active releases since we can exclude the archived.

rebased onto f2b313de8b53ad3f4b894d6af64dd3c7c51361c0

@onosek would you be the right person to review these changes?

Hello, I am sorry for the delay. Initially, I started reviewing the PR, but later I was assigned to a project with higher priority. I am back now so I can focus on this again.
I will look at it once more, because I forgot the details since then.

In the past, I tried to search for "service_levels" (sls) among old branch requests. I didn't find any usage. I don't know whether it still has some purpose. I would say it doesn't. But the safer approach is just to strip the PRC (like you did) and keep the rest.

pretty please pagure-ci rebuild

please don't forget fedpkg releases-info

ack show_releases_info

cli.py
547:        parser.set_defaults(command=self.show_releases_info)
1450:    def show_releases_info(self):
def show_releases_info(self):
        server_url = self.config.get('{0}.pdc'.format(self.name), 'url')

I think Lenka changed show_releases_info correctly. It gets data from the Bodhi.

I will just change

    active_branches = []
    for active_branch in query_bodhi(server_url):
        if active_branch not in active_branches:
            active_branches.append(active_branch)

|
|
v

    active_branches = set(query_bodhi(server_url))

because it appears to be more readable to me.

Commit 9a7f4629 fixes this pull-request

Pull-Request has been merged by onosek

I finally did some testing. Thanks for the change.

Thanks a lot for the review!

Metadata