#473 Add --dry-run mode to request-branch
Opened by salimma. Modified
salimma/fedpkg dry-run  into  master

Download 473.patch

This would enable someone filing a bz to request a branch to quickly verify if such a branch request is valid or not

Signed-off-by: Michel Alexandre Salim salimma@fedoraproject.org

Tested by building a patched RPM locally:

fedpkg on  dry-run took 2s
❯ fedpkg request-branch --dry-run --repo luajit epel9
Would have filed: New Branch "epel9" for "rpms/luajit"
 ```
{
 "action": "new_branch",
 "branch": "epel9",
 "namespace": "rpms",
 "repo": "luajit",
 "create_git_branch": true
}
 ```

Hello,

You don't have to create a new parameter --dry-run for argument request-branch, instead we prefer using the top-level optional argument --dry-run which is inherited from rpkg. This will give you access to self.args.dry_run (since fedpkgClient inherits from cliClient) too.

The only difference will be that instead of calling fedpkg request-branch --dry-run ... you would call it like fedpkg --dry-run request-branch ....

Metadata