#410 More specific regex to detect bugs in changelog
Merged by onosek. Opened by onosek.
onosek/fedpkg bodhi_regex  into  master

Download 410.patch

Use regex similar to Bodhi's regex (with some minor changes)

Fixes: #404
JIRA: RHELCMP-815
Signed-off-by: Ondrej Nosek onosek@redhat.com

Generally looks good to me. If this is based on some Bodhi code, it might be nice to add a link to it in the commit message.

:thumbsup:

Actually, I didn't find a corresponding code in Bodhi. This was suggested to me by @mattia as "Bodhi code". Where is the repo I can check it? Otherwise, I will remove (or update) this comment to more correct form.
I tried just https://github.com/fedora-infra/bodhi and didn't find it there.

The regex definition is in config file:
https://github.com/fedora-infra/bodhi/blob/89f88190a74a30e289c0a7725efa7e3c075814c1/bodhi/server/config.py#L281-L283

It's then used in the automatic updates consumer:
https://github.com/fedora-infra/bodhi/blob/89f88190a74a30e289c0a7725efa7e3c075814c1/bodhi/server/consumers/automatic_updates.py#L155-L164

rebased onto 6567080bc2d2e6fcc8e20c3c33b423b5b347708d

rebased onto 08383d9496f84588a2bb842b67c4ac6dd9b45da3

rebased onto e97f2921c3b7aceacff72355785224f2ddd7ab23

Typos fixes were added.

Pull-Request has been merged by onosek

Metadata