fedpkg

#297 Make update work for containers
Merged by lsedlar. Opened by lsedlar.
lsedlar/fedpkg container-update  into  master

Download 297.patch

We don't really have an NVR available, but users can fill it in by themselves.

Fixes: https://pagure.io/fedpkg/issue/296

rebased onto 3d606d24ad2ad7dda293071e5ef3b6ba228df895

rebased onto b0ee984e005ae22b1ffdac25b2db58d1227e976b

Is path missing?

Good catch, yes, this will break if --path is used.

rebased onto bd5547053db29b0bf0c49dac3ec93ffbfb0ed52f

That's fine for me. Thanks.

LGTM

Just an idea, would it be good to add a separate property or method to indicate current repo type. The code depending on repo type would look like:

if cmd.is_rpm_repo:
    ...
if cmd.is_container_repo:
    ...
if cmd.is_modules_repo:
    ...

Pull-Request has been merged by lsedlar

@cqi It's an option, but it seems like a lot of work when new type is added and it does not really prevent any problems as far as I can tell. For example fedpkg verrel is still broken for containers.

@lsedlar I agree. Current implementation is good enough.
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.