#226 Drop support of bodhi-client 0.9
Merged by cqi. Opened by cqi.
cqi/fedpkg drop-bodhi-client-0.9  into  master

Download 226.patch

Fixes #223

Signed-off-by: Chenxiong Qi cqi@redhat.com

Is this correct? Wouldn't it report all existing versions as unsupported? Even Rawhide has only 3.8.0.

My silly mistake. Sorry.

rebased onto c2c97914843a61ccb472fe32f51cd1e1011136cc

pretty please pagure-ci rebuild

@lsedlar Fixed. PTAL.

The change looks good to me now.
I'm wondering if it would make sense to check the version sooner. Current code will let user fill in the template, then check the version, report an error and throw the template away. That's pretty evil. Though that should probably be a different PR.

I'm wondering if it would make sense to check the version sooner. Current code will let user fill in the template, then check the version, report an error and throw the template away. That's pretty evil. Though that should probably be a different PR.

Good Point! I'll make a PR for this. I also think to use bodhi client binding instead of the bodhi CLI to rewrite the update.

1 new commit added

  • Check bodhi version earlier

1 new commit added

  • Also remove bodhi url from config

pretty please pagure-ci rebuild

Looks good to me. :thumbsup:

3 new commits added

  • Also remove bodhi url from config
  • Check bodhi version earlier
  • Drop support of bodhi-client 0.9

@lsedlar There is a minor update to the last commit. That is to restore to pass bodhi config in a dict instead of passing single staging argument. When I was writing code for new override command, I found I'm repeating self.config.getboolean(section, 'staging'), at least three times. This minor change will be helpful to avoid that. Just a single call to get_bodhi_config simply.

Pull-Request has been merged by cqi

Metadata